Trim redundant comments from KubernetesExecutor lazy-Manager tests#69216
Merged
Conversation
The added tests carried a multi-line docstring and inline comments that restated what the test names and assertions already convey. Reducing them to the minimum keeps the intent while dropping the narration, following up on review feedback for apache#68800.
shahar1
requested review from
hussein-awala,
jedcunningham and
jscheffl
as code owners
boring-cyborg
Bot
added
area:providers
provider:cncf-kubernetes
Miretpl
approved these changes
Jul 1, 2026
Miretpl
left a comment
Miretpl
left a comment
Contributor
There was a problem hiding this comment.
I've had the same thought when I skimmed through the PR.
SameerMesiah97
approved these changes
Jul 1, 2026
eladkal
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #68800. The tests added there carried a multi-line docstring and a couple of inline comments that just restated what the test names and assertions already convey. This trims them to the minimum — the intent stays, the narration goes — per review feedback on that PR.
Test-only, comment/docstring change; no behaviour change.
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines